-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize noop_waker #133089
Draft
eholk
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
eholk:stabilize-noop-waker
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Stabilize noop_waker #133089
+101
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eholk
added
the
I-libs-api-nominated
Nominated for discussion during a libs-api team meeting.
label
Nov 16, 2024
rustbot
added
PG-exploit-mitigations
Project group: Exploit mitigations
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Nov 16, 2024
The job Click to see the possible cause of the failure (guessed by this bot)
|
zachs18
reviewed
Nov 16, 2024
Comment on lines
+866
to
+867
#[stable(feature = "noop_waker", since = "CURRENT_RUSTC_VERSION")] | ||
#[rustc_const_stable(feature = "noop_waker", since = "CURRENT_RUSTC_VERSION")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LocalWaker
is itself still unstable, so I think this function should remain unstable, just under that feature gate?
Suggested change
#[stable(feature = "noop_waker", since = "CURRENT_RUSTC_VERSION")] | |
#[rustc_const_stable(feature = "noop_waker", since = "CURRENT_RUSTC_VERSION")] | |
#[unstable(feature = "local_waker", issue = "118959")] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I-libs-api-nominated
Nominated for discussion during a libs-api team meeting.
PG-exploit-mitigations
Project group: Exploit mitigations
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Issue: #98286
This is a handy feature that's been used widely in tests and example async code and it'd be nice to make it available to users.
cc @rust-lang/wg-async
Creating as a draft PR because T-libs-api will need to consider this and do an FCP before merging.