Expand CloneToUninit documentation.
#133055
Open
+135
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clarify relationship to `dyn` after rust-lang#133003. * Add an example of using it with `dyn` as rust-lang#133003 enabled. * Add an example of implementing it. * Add links to Rust Reference for the mentioned concepts. * Mention that its method should rarely be called. * Various small corrections.
This avoids confusion between “DeSTination” and “Dynamically-Sized Type”.
rustbot
added
S-waiting-on-review
zachs18
approved these changes
Nov 15, 2024
Comment on lines
+294
to
+295
| /// // We use `pointer::write()` instead of assignment because the destination may be | ||
| /// // uninitialized. |
There was a problem hiding this comment.
IIUC it's fine to *ptr = value; for Copy types even if *ptr is uninitialized, but using write is definitely also correct here and doesn't distract from the example, and more importantly would also be correct for a non-Copy field with drop glue (where *ptr = value.clone(); wouldn't be correct, but ptr.write(value.clone()) would), so I think it's good to call out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dynafter MakeCloneToUninitdyn-compatible #133003.dynas MakeCloneToUninitdyn-compatible #133003 enabled.dstwithdestto avoid confusion between abbreviations for “DeSTination” and “Dynamically-Sized Type”.Please review the
unsafecode closely, as I am not an expert in the best possible ways to express these operations. (It might also be better to omit the implementation example entirely.)cc @zachs18 #126799