Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btree: add {Entry,VacantEntry}::insert_entry #133042

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Nov 14, 2024

This matches the recently-stabilized methods on HashMap entries. I've
reused tracking issue #65225 for now, but we may want to split it.

@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2024

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 14, 2024
This matches the recently-stabilized methods on `HashMap` entries. I've
reused tracking issue rust-lang#65225 for now, but we may want to split it.
@ibraheemdev
Copy link
Member

r? libs-api for new unstable API surface

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Nov 15, 2024
@rustbot rustbot assigned Amanieu and unassigned ibraheemdev Nov 15, 2024
@cuviper
Copy link
Member Author

cuviper commented Nov 16, 2024

FWIW, I'm also working on a BTreeSet entry API to match HashSet's, and insert_entry will come in handy. I could still create and use that internally, but I don't see why we shouldn't expose it publicly as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants