Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turn creating 8dot3 names off for windows for speed #133033

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

turn creating 8dot3 names off for windows for speed #133033

wants to merge 10 commits into from
+69 −35

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Nov 14, 2024 •
edited
Loading

r? @ghost

try-job: dist-x86_64-msvc

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 14, 2024
@klensy
Copy link
Contributor Author

klensy commented Nov 14, 2024

Try build, please

@jieyouxu
Copy link
Member

@bors try

@jieyouxu
Copy link
Member

@bors delegate+ (for try jobs)

@bors
Copy link
Contributor

bors commented Nov 14, 2024

✌️ @klensy, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

@bors
Copy link
Contributor

bors commented Nov 14, 2024

⌛ Trying commit 65584f9 with merge 747b9fe...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
@bors
Auto merge of rust-lang#133033 - klensy:win.dot, r=<try>
747b9fe 
turn creating 8dot3 names off for windows for speed

r? `@ghost`

try-job: x86_64-msvc
@jieyouxu jieyouxu added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Nov 14, 2024
@bors
Copy link
Contributor

bors commented Nov 14, 2024

☀️ Try build successful - checks-actions
Build commit: 747b9fe (747b9fe239452de253e5b5a7eae2911bc7398727)

@klensy
Copy link
Contributor Author

klensy commented Nov 14, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
@bors
Auto merge of rust-lang#133033 - klensy:win.dot, r=<try>
3495dfa 
turn creating 8dot3 names off for windows for speed

r? `@ghost`

try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Nov 14, 2024

⌛ Trying commit 362a86e with merge 3495dfa...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 14, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2024
@klensy
Copy link
Contributor Author

klensy commented Nov 14, 2024

@bors try

@bors
Copy link
Contributor

bors commented Nov 14, 2024

⌛ Trying commit 7e63636 with merge 8a8c508...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
@bors
Auto merge of rust-lang#133033 - klensy:win.dot, r=<try>
8a8c508 
turn creating 8dot3 names off for windows for speed

r? `@ghost`

try-job: x86_64-msvc
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 14, 2024

💔 Test failed - checks-actions

@Cajun75 Cajun75 mentioned this pull request Nov 14, 2024
Closed
@klensy
Copy link
Contributor Author

klensy commented Nov 14, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
@bors
Auto merge of rust-lang#133033 - klensy:win.dot, r=<try>
6510d30 
turn creating 8dot3 names off for windows for speed

r? `@ghost`

try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Nov 14, 2024

⌛ Trying commit 4018087 with merge 6510d30...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 14, 2024

💔 Test failed - checks-actions

@klensy klensy force-pushed the win.dot branch 2 times, most recently from 7d46f3c to efcfc02 Compare November 15, 2024 19:08
@klensy
Copy link
Contributor Author

klensy commented Nov 15, 2024

@bors try

@bors
Copy link
Contributor

bors commented Nov 15, 2024

⌛ Trying commit d7db01d with merge a58a7c3...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2024
@bors
Auto merge of rust-lang#133033 - klensy:win.dot, r=<try>
a58a7c3 
turn creating 8dot3 names off for windows for speed

r? `@ghost`

try-job: dist-x86_64-msvc
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 15, 2024

💔 Test failed - checks-actions

@klensy
Copy link
Contributor Author

klensy commented Nov 15, 2024

@bors try

@bors
Copy link
Contributor

bors commented Nov 15, 2024

⌛ Trying commit d7db01d with merge 3ba3f89188f96eeae16b913f9671048081fc09ab...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2024
@bors
Auto merge of rust-lang#133033 - klensy:win.dot, r=<try>
3ba3f89 
turn creating 8dot3 names off for windows for speed

r? `@ghost`

try-job: dist-x86_64-msvc
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2024
@bors
Auto merge of rust-lang#133076 - klensy:sccache-linux-bump, r=<try>
a0fe848 
bump sccache for linux x86_64 to allow caching while PGO'd

This bumps sccache for linux-only jobs to allow sccache work with PGO mozilla/sccache#952

This is improvement: 2h05m -> 1h44m (from 1 run) for `dist-x86_64-linux` rust-lang#133033 (comment)

Why still use old release? Commit with improvement was old, so i used some release around. In future, more recent versions can be tested to see if there any improvements, while this one already gives one.

aarch64 update shouldn't change much, as there no PGO used.

For other OSes i will create separate PRs later.

r? infra
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 15, 2024

💔 Test failed - checks-actions

@klensy
Copy link
Contributor Author

klensy commented Nov 16, 2024

dist-x86_64-msvc's try job runs light version of auto build, skipping build of some things via DIST_TRY_BUILD, breaking wix build with recent pr #131365, as it currently ignores --skip.

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2024
@bors
Auto merge of rust-lang#133076 - klensy:sccache-linux-bump, r=<try>
fc7d7eb 
bump sccache for linux x86_64 to allow caching while PGO'd

This bumps sccache for linux-only jobs to allow sccache work with PGO mozilla/sccache#952

This is improvement: 2h05m -> 1h44m (from 1 run) for `dist-x86_64-linux` rust-lang#133033 (comment)

Why still use old release? Commit with improvement was old, so i used some release around. In future, more recent versions can be tested to see if there any improvements, while this one already gives one.

aarch64 update shouldn't change much, as there no PGO used.

For other OSes i will create separate PRs later.

r? infra
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Nov 16, 2024
@klensy
Copy link
Contributor Author

klensy commented Nov 16, 2024

with hopefully fixed wix
@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2024
@bors
Auto merge of rust-lang#133033 - klensy:win.dot, r=<try>
2df57d5 
turn creating 8dot3 names off for windows for speed

r? `@ghost`

try-job: dist-x86_64-msvc
@bors
Copy link
Contributor

bors commented Nov 16, 2024

⌛ Trying commit 229fdb3 with merge 2df57d5cdff44134cd2c8978d11d1338ae1e7d32...

@bors
Copy link
Contributor

bors commented Nov 16, 2024

💔 Test failed - checks-actions

@rust-log-analyzer
Copy link
Collaborator

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Updating files:  99% (49997/50457)
Updating files:  99% (50291/50457)
Updating files: 100% (50457/50457)
Updating files: 100% (50457/50457), done.
branch 'try' set up to track 'origin/try'.
Switched to a new branch 'try'
[command]"C:\Program Files\Git\bin\git.exe" log -1 --format=%H
2df57d5cdff44134cd2c8978d11d1338ae1e7d32
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
---
file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config remote.upstream.fetch=+refs/heads/*:refs/remotes/upstream/*
file:.git/config submodule.library/backtrace.active=true
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
---
[2024-11-16T09:51:38Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-11-16T09:51:41Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-11-16T09:51:41Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpkxHjOX#[email protected]" "--lib" "--" "--wrap-rustc-with" "Eprintln"
[2024-11-16T09:52:09Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
[2024-11-16T09:52:09Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpkxHjOX#[email protected]" "--lib" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpkxHjOX\\incremental-state"
[2024-11-16T09:52:43Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrUnchanged), patch=None, backend=Llvm, phase=benchmark
[2024-11-16T09:52:43Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpkxHjOX#[email protected]" "--lib" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpkxHjOX\\incremental-state"
[2024-11-16T09:52:49Z DEBUG collector::compile::benchmark::patch] applying println to "C:\\a\\_temp\\msys64\\tmp\\.tmpkxHjOX"
[2024-11-16T09:52:49Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" }), backend=Llvm, phase=benchmark
[2024-11-16T09:52:49Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" }), backend=Llvm, phase=benchmark
[2024-11-16T09:52:49Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpkxHjOX#[email protected]" "--lib" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpkxHjOX\\incremental-state"
[2024-11-16T09:52:55Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-11-16T09:52:57Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Opt, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-11-16T09:52:57Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpUat4wy#[email protected]" "--release" "--lib" "--" "--wrap-rustc-with" "Eprintln"
[2024-11-16T09:53:54Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
---
Skipping Set({dist::miri}) because it is excluded
Dist rust-nightly-x86_64-pc-windows-msvc
 finished in 69.477 seconds
rust.wxs
C:\a\rust\rust\build\tmp\dist\combined-tarball\rust.wxs(172) : error CNDL0150 : Undefined preprocessor variable '$(env.CFG_RUSTFMT)'.
Command has failed. Rerun with -v to see more details.
[2024-11-16T11:24:59.842Z INFO  opt_dist::timer] Section `Stage 5 (final build)` ended: FAIL (2632.78s)`
[2024-11-16T11:24:59.842Z INFO  opt_dist] Timer results
    -----------------------------------------------------------------
    Stage 1 (Rustc PGO):                            4167.02s (46.99%)
---
[2024-11-16T11:25:00.879Z INFO  opt_dist::utils] Free disk space: 103.09 GiB out of total 299.51 GiB (65.58% used)
Error: Optimized build pipeline has failed

Caused by:
    Command RUST_BACKTRACE=full python x.py dist bootstrap --include-default-paths --skip rust-docs --skip rustc-docs --skip rust-docs-json --skip rust-analyzer --skip rustc-src --skip clippy --skip miri --skip rustfmt --llvm-profile-use C:\a\rust\rust\opt-artifacts\llvm-pgo.profdata --rust-profile-use C:\a\rust\rust\opt-artifacts\rustc-pgo.profdata --keep-stage 0 --keep-stage 1 [at C:\a\rust\rust] has failed with exit code Some(1)
Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@klensy @jieyouxu @bors @rust-log-analyzer @rustbot