Fix gemcutter:import:process
#5198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It creates a `Pusher` with the first argument being a user but it expects an API key. Similarly, the api key/user must be present in the database for validations.
|
well spotted 💪 Any particular reason to use import task even with advanced seed we have today? I had no need to use import task in last month since I'm happy seed user. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5198 +/- ##
==========================================
- Coverage 96.06% 93.22% -2.84%
==========================================
Files 430 430
Lines 9120 9179 +59
==========================================
- Hits 8761 8557 -204
- Misses 359 622 +263 ☔ View full report in Codecov by Sentry. |
|
I'm trying to understand why https://rubygems.org/gems/pry/reverse_dependencies (not the only one) shows dependencies multiple times. I can download a bunch of versions, put them in a directory to import and see what happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It creates a
Pusherwith the first argument being a user but it expects an API key.Similarly, the api key/user must be present in the database for validations.
Broken since #4213. With this change, I was able to import from a fresh install.