Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source/layouts/layout.haml #748

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

tnir
Copy link
Collaborator

@tnir tnir commented Jul 24, 2022

Closes #747

This PR focuses on removal of source/layouts/layout.haml, which is the default filename. In addition, the most common layout in this project source/layouts/base.haml has been referred from customized layout files. In another place, we may change base to the default name.

Signed-off-by: Takuya Noguchi [email protected]

@tnir tnir self-assigned this Jul 24, 2022
@tnir tnir added architecture/cleanup architecture/legacy or broken Legacy and/or broken architecture labels Jul 24, 2022
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-747-remove-rw2bxv July 24, 2022 13:17 Inactive
@tnir tnir added this to the Architecture overhaul milestone Jul 24, 2022
@tnir
Copy link
Collaborator Author

tnir commented Jul 24, 2022

20c2643 was not so good since the default layout is now missing.

@tnir tnir force-pushed the 747-remove-sourcelayoutslayouthaml branch from 20c2643 to c935c6a Compare July 24, 2022 23:36
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-747-remove-rw2bxv July 24, 2022 23:37 Inactive
@tnir tnir force-pushed the 747-remove-sourcelayoutslayouthaml branch from c935c6a to 184dc9e Compare July 24, 2022 23:37
@deivid-rodriguez deivid-rodriguez temporarily deployed to bundler-site-747-remove-rw2bxv July 24, 2022 23:37 Inactive
@tnir
Copy link
Collaborator Author

tnir commented Jul 25, 2022

Thanks. Merging.

@tnir tnir merged commit af0b778 into master Jul 25, 2022
@tnir tnir deleted the 747-remove-sourcelayoutslayouthaml branch July 25, 2022 00:06
config.rb Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove source/layouts/layout.haml
3 participants