Bump haml to 6.3

There were two issues: * Pages using the two column layout were duplicating content. I identified the issue as related to the weird usage of `content_for` inside `wrap_layout`. I removed that because it was also making the template structure harder to follow. * Sometimes HTML entities were not being properly interpreted. Fixed by switching to use `!=` in those cases. Signed-off-by: Takuya Noguchi <[email protected]>
rubygems · Jan 15, 2025 · 95c8476 · 95c8476
1 parent 85e4c2c
commit 95c8476
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 15 deletions.
diff --git a/Gemfile b/Gemfile
@@ -10,7 +10,7 @@ gem "middleman-syntax"
 
 ## Template engines
 gem "builder"
-gem "haml", "~> 5.2.2"
+gem "haml", "~> 6.3"
 gem "kramdown"
 
 # Rake tasks

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -106,8 +106,9 @@ GEM
     ffi (1.17.1)
     ffi (1.17.1-arm64-darwin)
     ffi (1.17.1-x86_64-linux-gnu)
-    haml (5.2.2)
-      temple (>= 0.8.0)
+    haml (6.3.0)
+      temple (>= 0.8.2)
+      thor
       tilt
     haml_lint (0.59.0)
       haml (>= 5.0)
@@ -247,7 +248,7 @@ PLATFORMS
 DEPENDENCIES
   builder
   faraday-retry (~> 2.2)
-  haml (~> 5.2.2)
+  haml (~> 6.3)
   haml_lint (~> 0.59)
   irb
   kramdown

diff --git a/source/contributors.html.haml b/source/contributors.html.haml
@@ -48,7 +48,7 @@ title: Contributors
       - data.contributors.each do |c|
         %span.contributor
           = link_to c[:name], c[:href], title: "#{pluralize(c[:commits], "commit")}"
-          = "&nbsp;•&nbsp;" unless c == data.contributors.last
+          != "&nbsp;•&nbsp;" unless c == data.contributors.last
       %br
       %p
         …and everyone who has given time, effort, thought, or help, instead of git commits &lt;3
diff --git a/source/layouts/base.haml b/source/layouts/base.haml
@@ -30,7 +30,5 @@
 
     ~ yield
 
-    = yield_content :tail
-
     .footer
       = partial 'layouts/footer'
diff --git a/source/layouts/two_column_layout.haml b/source/layouts/two_column_layout.haml
@@ -5,13 +5,6 @@
   - content_for(:canonical, commands_toplevel_path(current_page.destination_path))
 
 ~ wrap_layout :base do
-  - content_for :tail do
-    .bg-light-blue
-      .container
-        .contents
-          .edit-on-github.text-center
-            = link_to_editable_version
-
   = partial 'partials/docs_header'
 
   .container
@@ -26,3 +19,9 @@
             = partial 'partials/guides_sidebar'
 
   = javascript_include_tag 'two_column_layout.min'
+
+  .bg-light-blue
+    .container
+      .contents
+        .edit-on-github.text-center
+          = link_to_editable_version
diff --git a/source/localizable/index.html.haml b/source/localizable/index.html.haml
@@ -9,7 +9,7 @@
 .container.py-5
   .mx-xl-5.px-xl-5.my-4.large-font
     %p= t('home.bundler_info1')
-    %p= t('home.bundler_info2')
+    %p!= t('home.bundler_info2')
 
   .d-grid.d-md-flex.gap-2.mx-auto.my-md-4.justify-content-md-center
     = link_to t('home.what_can_bundler_do'), "/guides/getting_started.html#getting-started", class: 'btn btn-primary btn-lg'
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,7 +30,5 @@ @@
         ~ yield
-        = yield_content :tail
         .footer
           = partial 'layouts/footer'