Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancel and back span helpers #1121

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bmorrall
Copy link

Resolves #1120

Description

Adds a helper for "<< Back" and "<< Cancel" button and link labels. Some of these values were inconsistent or incorrectly (if not at all) escaped, this at least keeps things consistent and easy to repeat.

Guide questions:

  • What motivated this change (if not already described in an issue)?
    • Desire to fix something on the internet somewhere/anywhere. Inconsistent text formatting once kicked my dog, couldn't stand by this time.
  • What alternative solutions did you consider?
    • find-replace/gsub text inline in all erb files.
  • What are the tradeoffs for your solution?
    • uses a extra method for something that could be hardcoded directly into the erb files.

List any dependencies that are required for this change. (gems, js libraries, etc.)

  • None

Include anything else we should know about. -->

  • Some libraries are a little out of date at the moment (nio4r), not willing to bump those without understanding the project more.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Open browser and visually verify text is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Back and Cancel Button text
1 participant