React 16 Support + Fix NPM links #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
reactto peerDependencySpecifying
reactas a dependency can cause multiple versions of React to be present in a single consumer build if there is a semver mismatch andnpm/yarnis unable to dedupe.Support
react@16AFAIK this library works just fine on
react@16, so specifying a semver range that includes 16.Fix npm links
The links specified in
package.jsonwere pointing to a non-existing repository on https://www.npmjs.com/package/wired-elements-reactAdd
sideEffectsSpecifying
"sideEffects": falsein thepackage.jsonwill enable bundlers like webpack to tree-shake the module.