AddedUserNameReq #542
Open
AddedUserNameReq #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
- Coverage 67.19% 67.16% -0.04%
==========================================
Files 61 61
Lines 5795 5801 +6
==========================================
+ Hits 3894 3896 +2
- Misses 1901 1905 +4
Continue to review full report at Codecov.
|
sbillinge
reviewed
Jul 9, 2020
| @@ -88,18 +88,19 @@ def push_git(store, path, rc): | |||
| subprocess.check_call(cmd, cwd=storedir) | |||
| if "default_user_id" in rc: | |||
| cmd = ["git", "commit", "-m", f"{rc.default_user_id} regolith auto-store commit"] | |||
There was a problem hiding this comment.
see my comment on the other PR. It looks as we may need default_github_id in regolithrc.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oddly I am getting an error on the html builder, but I don't think that has anything to do with this change.
This PR has to do with our previously discussed change to require that the user have some sort of identifier to be automatically inserted into the commit message for the regolith heap