Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to node20 runtime and resolve bug with Http keepAlive settings #106

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Bump to node20 runtime and resolve bug with Http keepAlive settings #106

merged 1 commit into from
Jul 23, 2024

Conversation

komish
Copy link
Contributor

@komish komish commented Jul 19, 2024

Description

Related Issue(s)

Fixes #105

Checklist

  • This PR includes a documentation change
  • This PR does not need a documentation change

  • This PR includes test changes
  • This PR's changes are already tested

  • This change is not user-facing
  • This change is a patch change
  • This change is a minor change
  • This change is a major (breaking) change

Changes made

See above.

Copy link

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adambkaplan
Copy link

@divyansh42 are you able to approve this?

package.json Show resolved Hide resolved
@komish
Copy link
Contributor Author

komish commented Jul 22, 2024

Thanks @adambkaplan @divyansh42

Copy link
Member

@divyansh42 divyansh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@divyansh42
Copy link
Member

I am just checking why these tests are not running

@divyansh42
Copy link
Member

divyansh42 commented Jul 22, 2024

Could you please try to push some changes again so that it triggers the CI checks. Maybe an empty commit

@komish
Copy link
Contributor Author

komish commented Jul 22, 2024

@divyansh42 maybe there are branch protection rules preventing it these from running? They've not executed for any of my commits so far, I just assumed they were waiting for something (label or otherwise).

@komish
Copy link
Contributor Author

komish commented Jul 22, 2024

@divyansh42 Looking at previously merged PRs, I'm thinking you maybe have a branch protection rule that depends on this workflow to run and label a PR https://github.com/redhat-actions/openshift-tools-installer/actions/workflows/security_scan.yml - but this workflow is showing as disabled to me.

@github-actions github-actions bot added the CRDA Scan Pending CRDA scan waiting for approval label Jul 22, 2024
@divyansh42 divyansh42 added the CRDA Scan Approved CRDA scan approved by a collaborator label Jul 22, 2024
@github-actions github-actions bot added CRDA Scan Failed CRDA scan failed unexpectedly and removed CRDA Scan Pending CRDA scan waiting for approval labels Jul 22, 2024
@divyansh42
Copy link
Member

divyansh42 commented Jul 22, 2024

@adambkaplan do you want to take a look at the changes once as a few things got changed again?

Copy link

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good.

@github-actions github-actions bot added CRDA Scan Pending CRDA scan waiting for approval and removed CRDA Scan Failed CRDA scan failed unexpectedly CRDA Scan Approved CRDA scan approved by a collaborator labels Jul 23, 2024
@divyansh42 divyansh42 merged commit 51637a7 into redhat-actions:main Jul 23, 2024
4 checks passed
@divyansh42
Copy link
Member

The updated action has been released.
Changes should reflect in v1 and v1.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CRDA Scan Pending CRDA scan waiting for approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Task executes but step seems to hang for 3 minutes before it completes
4 participants