-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add animatedKeyboardHeight in useKeyboard hook #140
base: main
Are you sure you want to change the base?
Add animatedKeyboardHeight in useKeyboard hook #140
Conversation
Co-Authored-By: Linus Unnebäck <[email protected]>
This looks great! Would love to see a Snack posted so that I can try it out Currently it doesn't seem to handle when the keyboard changes height? 🤔 e.g. when switching between emoji and text input |
You can find the snack just here: https://snack.expo.io/@magrin_j/usekeyboard-animatedkeyboardheight It's actually working even if the keyboard height change when switching between classic keyboard and emoji by example. In the snack I've added an extra 150ms duration in the animation because when it's a switch between two kind of keyboard the duration is set to 0, what do you think about that, we should actually put a default duration no ? |
Since the keyboard itself isn't animated when we are switching between different layouts, I think that the duration should stay as 0 in those cases. I think that an important use case that should be addressed by this is having a view that spans the entire screen, but doesn't get covered by the keyboard. The goal here is that the view should always be the exact space visible over the keyboard and thus it's important that the durations are exactly the same as how the keyboard moves. If we added an extra duration, elements would be partially covered by the keyboard when switching to a higher layout, and then they would animate up from under the keyboard. Since the OS doesn't have an animation when switching layouts, I don't think we should either I've modified the Snack slightly here to show what I mean: https://snack.expo.io/@linusu/usekeyboard-animatedkeyboardheight-linusu As you can see it is almost perfect, it's just the easing curves that are off a bit (at least on iOS, haven't had time to test Android yet).
I know that this might be crazy levels of attention to details 😂 but I would really like to get this within a few pixels of right so that it looks really nice for the app I'm currently working on! |
Okay, I have all the points now, I just need to figure out the curve to produce them 😁
|
Ok, you're right, it's better to keep the duration to 0 as it's not animated during the switch 🙂 For the easing curve, I guess we can take a look of what's using natively to produce the animation, like |
@LinusU Apparently with facebook/react-native#4812 The animation curse is defined like that in Native side: |
Ahh, cool, I've never heard of I managed to create a very close beizer curve by simply overlaying a plot of the values I collected and playing with the knobs 😄 But for some reason the duration of the animation simply isn't correct 🤔 I have to add |
@LinusU Yes, it’s actually still experimental on Android, and it’s not working with Animated.Value from what I’ve understood. Really strange for the extra duration as without, it actually match time. Not the curve, but the time should be fine 😕 When you’ve done your screenshot and to estimate the frame and height, did you enable the slow animation mode ? If so, the duration will not match as it’s slowed |
Yes I tried running in slow mode, the problem is that the duration is still reported as I would really like to know the slow down factor as it would help me debugging the delay issue. If I multiply the duration by 20x, the duration seem to match perfectly when running in slow mode without me adding the extra duration. If I multiply by 12x and also add 12x my extra duration, everything also matches up. When running in normal mode, both in simulator and on device, I need the to add the extra duration in order for the animations to match 😕 |
Sorry for the delay, I'm little bit busy this week, I'll try to take a look as soon as I can, let me know if you figure it out ! 👍 |
No worries, I've had a very busy week as well, might get some more time this weekend |
Summary
In order to animate properly based on the keyboard apparition, this PR add a new value in
useKeyboard
hook calledanimatedKeyboardHeight
.It also add a new hook
useAnimatedValue
that just wrap theAnimated.Value
into auseRef
hook.Solve #81
Test Plan
Compatibility
Checklist
README.md