Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noticket snow incident changed update #2719

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

ewilson-r7
Copy link
Collaborator

Proposed Changes

Description

Describe the proposed changes:

  • Updated Incident Changed trigger to accept additional input.

PR Requirements

Developers, verify you have completed the following items by checking them off:

Testing

Unit Tests

Review our documentation on generating and writing plugin unit tests

  • Unit tests written for any new or updated code

In-Product Tests

If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:

  • Screenshot of job output with the plugin changes
  • Screenshot of the changed connection, actions, or triggers input within the InsightConnect workflow builder

Style

Review the style guide

  • For dependencies, pin OS package and Python package versions
  • For security, set least privileged account with USER nobody in the Dockerfile when possible
  • For size, use the slim SDK images when possible: rapid7/insightconnect-python-3-38-slim-plugin:{sdk-version-num} and rapid7/insightconnect-python-3-38-plugin:{sdk-version-num}
  • For error handling, use of PluginException and ConnectionTestException
  • For logging, use self.logger
  • For docs, use changelog style
  • For docs, validate markdown with insight-plugin validate which calls icon_validate to lint help.md

Functional Checklist

  • Work fully completed
  • Functional
    • Any new actions/triggers include JSON test files in the tests/ directory created with insight-plugin samples
    • Tests should all pass unless it's a negative test. Negative tests have a naming convention of tests/$action_bad.json
    • Unsuccessful tests should fail by raising an exception causing the plugin to die and an object should be returned on successful test
    • Add functioning test results to PR, sanitize any output if necessary
      • Single action/trigger insight-plugin run -T tests/example.json --debug --jq
      • All actions/triggers shortcut insight-plugin run -T all --debug --jq (use PR format at end)
    • Add functioning run results to PR, sanitize any output if necessary
      • Single action/trigger insight-plugin run -R tests/example.json --debug --jq
      • All actions/triggers shortcut insight-plugin run --debug --jq (use PR format at end)

Assessment

You must validate your work to reviewers:

  1. Run insight-plugin validate and make sure everything passes
  2. Run the assessment tool: insight-plugin run -A. For single action validation: insight-plugin run tests/{file}.json -A
  3. Copy (insight-plugin ... | pbcopy) and paste the output in a new post on this PR
  4. Add required screenshots from the In-Product Tests section

SamhithaTatipalli and others added 23 commits August 12, 2024 15:42
* Initial commit for armorblox plugin

* Fix validate errors

* Timestamp changes

* Updated armorblox-sdk 0.1.4 version in requirements.txt

* Updated the suggestions for plugin.spec.yaml

* Update plugins/armorblox/help.md

* Update plugins/armorblox/help.md

* Update plugins/armorblox/help.md

* Update plugins/armorblox/help.md

* Update plugins/armorblox/help.md

* Update plugins/armorblox/help.md

* Update plugins/armorblox/help.md

* Updated review comments

* Update plugins/armorblox/icon_armorblox/triggers/get_incidents/schema.py

* Update plugins/armorblox/unit_test/payloads/get_remediation_action.json

* Update plugins/armorblox/unit_test/payloads/get_remediation_action.json

* Updated armorblox plugin with the required fixes

* Updated plugin with latest fixes

* Updated plugin with parameterized on test cases

* "Fixed review comments"

* Updated support field to community in plugin.spec.yaml

---------

Co-authored-by: Ankita Sharma <[email protected]>
Co-authored-by: Rajat Upadhyaya <[email protected]>
* Upgrade user to root, bump version to 304

* Remove full stop and overlapping link

* Restore dockerfile
* SOAR-17026-Bumping requirements of requests

* SOAR-17026-Bumping requirements cryptography and idna
* Task connection test & SDK Bump

* Lint

* Adding additional exception handling

* Fixing validator

* Fixing validator pt2

* SOAR-17320: add html unit tests files

* Fixing error

* Fixing schema and exception

* Changing egress exception handling

---------

Co-authored-by: joneill-r7 <[email protected]>
* Powershell | Update SDK

* Update help.md
* Add connection test for task

* Update test logs and version log

* Fix checksum
* Initial commit

* Rebase

* Rebase

* help.md

* help.md

* Rebase

* Refresh
…onary (#2707)

* SOAR-17400-return connection test pass a dict

* SOAR-17400-Adding a timeout to the connection test requests

* SOAR-17400-moving create user to rest api call do products now being a required field

* SOAR-17400-moving create user to rest api call do products now being a required field

* SOAR-17400-moving create user to rest api call do products now being a required field
* First draft:

* Save point

* Successful connection test

* Fix unit test and add more error handling

* Try to patch get current time method

* Restore get current time & loop over each api call

* Restore unit test imports

* Add in cause assist for final exception

* Nvm, remove cause and assist

* Update error messaging

* Updates

* Suggested fixes

* Loggers everywhere
* Task connection test added & SDK Bump

* Changing logging
@ewilson-r7 ewilson-r7 changed the base branch from master to develop August 19, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants