Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[setup-r]: macOS: unlink pre-installed pkg-config #953

Merged
merged 9 commits into from
Nov 25, 2024

Conversation

gaborcsardi
Copy link
Member

@gaborcsardi gaborcsardi commented Nov 25, 2024

Closes #948.

It conflicts with the new pkgconf version that
we are trying to install, and which should be
the default going forward.

#948
@gaborcsardi gaborcsardi changed the title Add debug to R-devel workflow [setup-r]: macOS: unlink pre-installed pkg-config Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (e8c6069) to head (fbfaaae).
Report is 1 commits behind head on v2-branch.

Additional details and impacted files
@@            Coverage Diff             @@
##           v2-branch     #953   +/-   ##
==========================================
  Coverage      84.61%   84.61%           
==========================================
  Files              3        3           
  Lines             13       13           
==========================================
  Hits              11       11           
  Misses             2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@gaborcsardi gaborcsardi requested a review from jeroen November 25, 2024 08:39
jeroen
jeroen previously approved these changes Nov 25, 2024
@gaborcsardi gaborcsardi merged commit 473c681 into v2-branch Nov 25, 2024
30 checks passed
@jeroen jeroen deleted the fix/macos-brew-pkg-config-mishap branch November 25, 2024 09:50
@stibu81
Copy link

stibu81 commented Nov 25, 2024

This also fixes #950.

Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to get R devel: Failed to get R 4.5.0 (Mac 14)
3 participants