Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce welcome page in /maven #266

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Introduce welcome page in /maven #266

merged 4 commits into from
Nov 5, 2024

Conversation

gastaldi
Copy link
Collaborator

@gastaldi gastaldi commented Nov 5, 2024

@aloubyansky
Copy link
Member

Is the text supposed to be re-usable between registry.quarkus.io and registry.quarkus.redhat.com?

Otherwise, I'd suggest something like:

This endpoint provides Quarkus platform and extension metadata in the form of Maven artifacts for Quarkus Dev Tools clients, such as code.quarkus.io and Quarkus CLI.

@gastaldi
Copy link
Collaborator Author

gastaldi commented Nov 5, 2024

Is the text supposed to be re-usable between registry.quarkus.io and registry.quarkus.redhat.com?

Yes, it's supposed to be merely informative in case anyone browses to /maven instead of getting the confusing 404.

Here is the updated screenshot with your suggestion:

Screenshot 2024-11-05 at 16 53 38

@aloubyansky
Copy link
Member

Then we probably shouldn't link to code.quarkus.io?

Thanks for this, btw!

@gastaldi
Copy link
Collaborator Author

gastaldi commented Nov 5, 2024

How about linking to https://quarkus.io/guides/extension-registry-user instead? eg.

This endpoint provides Quarkus platform and extension metadata in the form of Maven artifacts for Quarkus Registry user clients

Screenshot 2024-11-05 at 17 40 27

Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of minor text adjustments, otherwise looks good to me. Thanks!

Co-authored-by: Alexey Loubyansky <[email protected]>
@gastaldi gastaldi merged commit 9dba954 into main Nov 5, 2024
1 check passed
@gastaldi gastaldi deleted the maven_welcome_page branch November 5, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a welcome page in /maven
2 participants