allow python version=3.12 in docker script build_image.sh #3332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabridamicelli
added a commit
to fabridamicelli/torchserve-docker
that referenced
this pull request
Oct 1, 2024
TorchServe blocks the build. We can get 3.12 back when this PR upstream is merged: pytorch/serve#3332
|
Hi @mreso any ideas/comments on this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Docker images are built using the script
build_image.shwhich takes the argumentpythonversion.Currently only versions 3.8, 3.9, 3.10 and 3.11 are allowed.
To the best of my knowledge there is no reason why we should not allow python 3.12 (please correct me if I am wrong).
This PR extends that list to include 3.12.
PS: If it is indeed the case that we should not allow 3.12, then it would be great to update the readme for consistency (currently only specifies
python >= 3.8)Type of change
Feature/Issue validation/testing