Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 735: Add a canonical spec link #4209

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

sirosen
Copy link
Contributor

@sirosen sirosen commented Jan 17, 2025

Now that a specification document is in place on the packaging site, it is possible to update this PEP to link to it.


The PR templates don't seem to fit this case exactly, so I assume it's fine to make this change like so.


📚 Documentation preview 📚: https://pep-previews--4209.org.readthedocs.build/

@sirosen sirosen requested a review from brettcannon as a code owner January 17, 2025 05:24
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally add canonical links when marking PEPs as Final. Is there anything outstanding before doing so here?

A

peps/pep-0735.rst Show resolved Hide resolved
Co-authored-by: Adam Turner <[email protected]>
@sirosen
Copy link
Contributor Author

sirosen commented Jan 17, 2025

Ah, maybe I was mistaken about this being the time to do this. It's been on my to-do list, but I don't know if there are other steps to take before it's marked Final.

I'll reread the difference between Accepted and Final to make sure I understand.

@brettcannon brettcannon merged commit 1478f6e into python:main Jan 17, 2025
5 checks passed
@brettcannon
Copy link
Member

I may have hit "merge" a bit too fast. 😅 But I also noticed that Paul didn't specify an acceptance criteria to transition to Final.

@sirosen sirosen deleted the pep735-add-spec-link branch January 17, 2025 18:58
@sirosen
Copy link
Contributor Author

sirosen commented Jan 17, 2025

I can do a fast-follow PR to mark it Final. I don't think there's anything left for a packaging PEP. Should I?

@AA-Turner
Copy link
Member

PEP 1 says:

If changes based on implementation experience and user feedback are made to Standards track PEPs while in the Provisional or (with SC approval) Accepted state, they should be noted in the PEP, such that the PEP accurately describes the implementation at the point where it is marked Final.

So unless implementation of PEP 735 led to anything that should be updated in the text, it makes sense to open the PR to mark 735 as Final -- we can ask Paul to review that one to confirm. Thank you!

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants