-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note on change in pre-release behavior from Packaging 24.2 #13163
base: main
Are you sure you want to change the base?
Conversation
7b01145
to
4266c13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree that it doesn't read particularly easily, but it does get the details across with the appropriate nuance for someone who doesn't know the PEP 440 rules inside and out (read: me).
I did try to think of ways to improve the phrasing, but I came up empty-handed.
I realized I was effectively saying some stuff twice, I think I've improved it a little. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah, that's much better!
pre-commit.ci autofix |
I'd prefer we keep this as a separate bugfix/feature changelog note, instead of amending the vendoring note. As of now, users can reasonably ignore the vendoring section which is basically only for redistributors/reference today. |
501b9e3
to
679deb7
Compare
Reasonable, updated. |
Not sure if this is too verbose? But didn't know how else to clearly explain it.