Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on change in pre-release behavior from Packaging 24.2 #13163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

notatallshaw
Copy link
Member

Not sure if this is too verbose? But didn't know how else to clearly explain it.

@notatallshaw notatallshaw force-pushed the packaging-vendor-news branch from 7b01145 to 4266c13 Compare January 12, 2025 22:41
@notatallshaw notatallshaw added this to the 25.0 milestone Jan 12, 2025
@ichard26 ichard26 added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 13, 2025
Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree that it doesn't read particularly easily, but it does get the details across with the appropriate nuance for someone who doesn't know the PEP 440 rules inside and out (read: me).

I did try to think of ways to improve the phrasing, but I came up empty-handed.

news/packaging.vendor.rst Outdated Show resolved Hide resolved
@ichard26 ichard26 requested a review from sbidoul January 13, 2025 03:56
@notatallshaw
Copy link
Member Author

I realized I was effectively saying some stuff twice, I think I've improved it a little.

Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, that's much better!

news/packaging.vendor.rst Outdated Show resolved Hide resolved
@ichard26
Copy link
Member

pre-commit.ci autofix

@pradyunsg
Copy link
Member

I'd prefer we keep this as a separate bugfix/feature changelog note, instead of amending the vendoring note.

As of now, users can reasonably ignore the vendoring section which is basically only for redistributors/reference today.

@notatallshaw notatallshaw changed the title Update packaging vendor news Add note on change in pre-release behavior from Packaging 24.2 Jan 13, 2025
@notatallshaw notatallshaw force-pushed the packaging-vendor-news branch from 501b9e3 to 679deb7 Compare January 13, 2025 12:45
@notatallshaw
Copy link
Member Author

I'd prefer we keep this as a separate bugfix/feature changelog note, instead of amending the vendoring note.

Reasonable, updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants