Duck array ops for all and any
#9883
Open
+32
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With a simple search I see that there's a bunch of |
for more information, see https://pre-commit.ci
tomwhite
force-pushed
the
duck-array-all-any
branch
from
f67c87d to
d8367b2
Compare
|
I updated this to replace more |
for more information, see https://pre-commit.ci
dcherian
approved these changes
Jan 15, 2025
dcherian
reviewed
Jan 15, 2025
| @@ -204,9 +204,9 @@ def format_items(x): | |||
| day_part = x[~pd.isnull(x)].astype("timedelta64[D]").astype("timedelta64[ns]") | |||
| time_needed = x[~pd.isnull(x)] != day_part | |||
| day_needed = day_part != np.timedelta64(0, "ns") | |||
| if np.logical_not(day_needed).all(): | |||
| if array_all(np.logical_not(day_needed)): | |||
There was a problem hiding this comment.
surprised we haven't updated the logical_not yet
There was a problem hiding this comment.
Could just use
Suggested change
| if array_all(np.logical_not(day_needed)): | |
| if array_all(~day_needed): |
Or not?
There was a problem hiding this comment.
I think ~ is np.invert/xp.bitwise_invert, so possibly different? I'll leave this for a future PR if that's OK.
headtr1ck
approved these changes
Jan 16, 2025
| @@ -204,9 +204,9 @@ def format_items(x): | |||
| day_part = x[~pd.isnull(x)].astype("timedelta64[D]").astype("timedelta64[ns]") | |||
| time_needed = x[~pd.isnull(x)] != day_part | |||
| day_needed = day_part != np.timedelta64(0, "ns") | |||
| if np.logical_not(day_needed).all(): | |||
| if array_all(np.logical_not(day_needed)): | |||
There was a problem hiding this comment.
Could just use
Suggested change
| if array_all(np.logical_not(day_needed)): | |
| if array_all(~day_needed): |
Or not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another change to use
duck_array_opsfor some instances ofallandany.whats-new.rstapi.rst