(fix): extension array indexers #9671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore/variable.py to use any-precision datetime/timedelta with autmatic inferring of resolution
…ocessing, raise now early
…t resolution, fix code and tests to allow this
for more information, see https://pre-commit.ci
… more carefully, for now using pd.Series to covert `OMm` type datetimes/timedeltas (will result in ns precision)
…rray` series creating an extension array when `.array` is accessed
…ithin decode_cf_timedelta
…ll back to cftime encoding, add fix for cftime issue where python datetimes are not encoded correctly with date2num.
Co-authored-by: Spencer Clark <[email protected]>
* Fix timedelta encoding overflow issue; always decode to ns resolution * Implement time_unit for decode_cf_timedelta * Reduce diff
Co-authored-by: Kai Mühlbauer <[email protected]>
|
@ilan-gold Can you rebase your changes on latest main? PR #9618 just got merged. |
I think I did. The tests look good but I'll have to re-check tomorrow - it was just mypy failing before but now I picked up an actual test failure |
|
Yes, looks clean. I was irritated by the amount of commits. But this will be squashed anyway, or do I miss something. The error ERROR xarray/tests/test_distributed.py::test_dask_distributed_zarr_integration_test[True-True] - Failed: 9 thread(s) were leaked from testseems unrelated. But it's also on main now. Not sure how to debug this... |
|
Great @kmuehlbauer - I want the maintainers to look at the MyPy. I could in theory fix it, but I would basically be guessing at what their wishes are for the classes' return types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical to kmuehlbauer#1 - probably not very helpful in terms of changes since https://github.com/kmuehlbauer/xarray/tree/any-time-resolution-2 contains most of it....
whats-new.rstapi.rst