[WIP] Add query tags. #331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Palazhchenko <[email protected]>
SuperQ
reviewed
Sep 6, 2018
| @@ -144,6 +148,15 @@ func (e *Exporter) scrape(ch chan<- prometheus.Metric) { | |||
| } | |||
| } | |||
|
|
|||
| func queryTag(query, name string) string { | |||
There was a problem hiding this comment.
This should probably be func tagQuery(query string, name string) string {.
| } | ||
|
|
||
| parts := strings.Split(query, " ") | ||
| return parts[0] + " /* mysqld_exporter:" + name + " */ " + strings.Join(parts[1:], " ") |
There was a problem hiding this comment.
How about this:
p := strings.SplitN(query, " ", 2)
return fmt.Sprintf("%s /* mysqld_exporter:%s */ %s", p[0], name, p[1])
| var logBin uint8 | ||
| err := db.QueryRow(logbinQuery).Scan(&logBin) | ||
| err := db.QueryRow(queryTag(`SELECT @@log_bin`, s.Name())).Scan(&logBin) |
There was a problem hiding this comment.
I would prefer to keep the const definition of the query. This shouldn't cause any type problems.
SuperQ
reviewed
Sep 6, 2018
| tagQueries = kingpin.Flag( | ||
| "exporter.tag-queries", | ||
| "TODO", | ||
| ).Default("false").Bool() |
There was a problem hiding this comment.
I don't think we need a flag for this, let's just add the feature so it's always on. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #241.
@SuperQ PTAL. Before I went too far – does it looks good?