Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement splineProperty #7471

Open
wants to merge 1 commit into
base: dev-2.0
Choose a base branch
from
Open

Implement splineProperty #7471

wants to merge 1 commit into from

Conversation

davepagurek
Copy link
Contributor

Resolves #6766

Changes:

  • Replaces splineEnds(mode) with splineProperty('ends', mode)
  • Replaces curveTightness(t) with splineProperty('tightness', t)
  • Fixes a bug where curve tightness was not being correctly passed to shapes
  • Adjusts the shift threshold in visual tests: I had bumped it up before to be lenient enough for text rendering in different environments, but this was making tests pass for a curve tightness test when they shouldn't. I've updated it to be lower by default, and able to be updated per-suite, so text tests can be more lenient.

@davepagurek davepagurek marked this pull request as ready for review January 16, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant