Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native redirects #383

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Native redirects #383

merged 4 commits into from
Oct 19, 2023

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Oct 16, 2023

This PR introduces a number of redirects from three legacy docsites to their /design counterparts: https://primer.style/cli/, https://primer.style/mobile/, and https://primer.style/desktop/. The legacy docsites were broken up into individual pages while the new docsites have combined entire sections into single pages. For that reason, rewriting legacy URLs to new docsite URLs makes use of functionality recently added to primer/design that allows linking to a specific anchor on the page.

Fixes https://github.com/github/primer/issues/1703
Fixes https://github.com/github/primer/issues/1702
Fixes https://github.com/github/primer/issues/1701

Copy link
Contributor

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified all links are working in the staging deployment ✅

Ship it 🚀

@camertron camertron merged commit 0d65d53 into main Oct 19, 2023
2 checks passed
@camertron camertron deleted the native_redirects branch October 19, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants