Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #73

Closed
wants to merge 23 commits into from
Closed

Add tests #73

wants to merge 23 commits into from

Conversation

nickserv
Copy link
Member

@nickserv nickserv commented Nov 2, 2019

Fixes #53

  • Expose code for testing
  • Test basic button injection
  • Create fully-functioning stubs
    • chrome.extension.storage.sync (needs to be custom)
    • MutationObserver
  • Attempt to test with mocked window.location
  • Test option syncing behavior
  • Scope ESLint config for tests
  • Consider adding more granular unit tests per class/file/method/function
  • Complete test coverage

package.json Outdated Show resolved Hide resolved
@kaicataldo
Copy link
Member

This is great! I would advocate for getting the testing infrastructure set up in this PR and landing it so that it frees other people up to start writing tests. What do you think?

@nickserv
Copy link
Member Author

nickserv commented Nov 5, 2019

This got a bit messy with some unrelated test code and configs being combined, so I'm going to split it up into multiple PRs.

@nickserv nickserv closed this Nov 5, 2019
@nickserv nickserv mentioned this pull request Nov 5, 2019
@nickserv nickserv deleted the testing-jest branch November 7, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests
2 participants