Reworked to use maven resolver #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Please squash commits |
If implemented this will upgrade the project off of the deprecated sonatype aether dependency to maven-resolver. * update to latest resolver and maven (move off org.sonatype) * keep all almost untouched (but mark deprecations)
infvg
force-pushed
the
rework-maven
branch
4 times, most recently
from
44f5481
to
09619a3
Compare
ZacBlanco
suggested changes
Oct 29, 2024
|
Just tacking on to add that I believe we'll need this update for the Java 21 work |
ZacBlanco
reviewed
Oct 29, 2024
ZacBlanco
reviewed
Oct 29, 2024
If merged, this PR will match the functionality that was previously provided by the old sonatype version. Remove downloadable check Move project builder instantiation to speed up resolution
ZacBlanco
approved these changes
Oct 29, 2024
|
@infvg please add Maven checks as a separate PR. We can merge that separately, then get Maven checks to run for this substantial refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reworked the project to use maven-resolver as opposed to the depreciated sonatype aether.
One important change is that DefaultArtifact has been deleted - I've used org.eclipse.aether.artifact.DefaultArtifact as it provides the same functionality.
Testing:
All the original unit tests are passing.