Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bin: replace .option with .command #17

Merged
merged 1 commit into from
Aug 2, 2020
Merged

bin: replace .option with .command #17

merged 1 commit into from
Aug 2, 2020

Conversation

AshCripps
Copy link
Contributor

fixes: #7

andrewhughes101
andrewhughes101 approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@andrewhughes101 andrewhughes101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing this 🎉

rodion-arr
rodion-arr approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@rodion-arr rodion-arr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dominykas
Copy link
Member

dominykas commented Aug 1, 2020 •
edited
Loading

  • At least 1 approval from package-maintenance members other than the author of the PR, unless there is single maintainer for the repository. In that case the single maintainer can land their own PRs.
  • No blocking reviews
  • 72 hours since the PR was openened

ljharb
ljharb approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like using the commands dir too :-) but that could be a followup if folks like the idea

@dominykas dominykas merged commit 4f151ab into pkgjs:master Aug 2, 2020
@AshCripps AshCripps deleted the use-yargs-command branch August 2, 2020 18:17
@dominykas
Copy link
Member

🎉 This PR is included in version 0.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewhughes101 andrewhughes101 andrewhughes101 approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@rodion-arr rodion-arr rodion-arr approved these changes

@dominykas dominykas dominykas approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a Yargs command for wiby test
6 participants
@AshCripps @dominykas @ljharb @rodion-arr @BethGriggs @andrewhughes101