fix fs.mkdir regression
#16497
Open
fix fs.mkdir regression
#16497
+135
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 10:28 PM PT - Jan 18th, 2025
❌ @dylan-conway, your commit 793860f has 1 failures in
🧪 try this PR locally: bunx bun-pr 16497 |
paperclover
previously approved these changes
Jan 18, 2025
I tested this build, it fixed my issue which I wrote in #16474 (comment) 👍 |
|
And another question, will you release a hotfix with this fix? |
This comment has been minimized.
This comment has been minimized.
|
This will be in Bun v1.1.46 which releases today (once the tests are fixed) |
dylan-conway
force-pushed
the
dylan/fix-mkdir
branch
from
3095611 to
cd234bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
recursive: truethrowing when the directory already existscloses #16474
How did you verify your code works?
Added a regression test