node:dgram compatibility improvements #16446
Draft
+2,416
−286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/bun.js/api/bun/udp_socket.zig
Outdated
| }; | ||
|
|
||
| if (iface_id) |id| { | ||
| address_slice[percent] = '\x00'; |
There was a problem hiding this comment.
is there always room in the buffer?
There was a problem hiding this comment.
Yes, because percent is always before the end of the buffer
There was a problem hiding this comment.
This is just to trick inet_pton into thinking the string is shorter than it actually is (specifically, that it doesn't contain %foo at the end).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the dgram module to add features and fix bugs. Adds some tests from Node.js.
How did you verify your code works?
Added tests.