Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Adds Elixir and Gleam as languages #4408

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

kikofernandez
Copy link
Contributor

What kind of change does this PR introduce?

Use the presence of property-based tests to detect the use of fuzzing in Elixir and Gleam code.

What is the current behavior?

There is no support for fuzz detection for Elixir and Gleam.

What is the new behavior (if this is a feature change)?**

Adds Elixir and Erlang as a client language.
Scans for the import of property-based test frameworks to detect the use of fuzzing in Elixir and Gleam

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

Support detection of fuzzing in Elixir and Gleam through the import of property-based testing modules

@kikofernandez kikofernandez requested a review from a team as a code owner November 9, 2024 19:48
@kikofernandez kikofernandez requested review from justaugustus and raghavkaul and removed request for a team November 9, 2024 19:48
@kikofernandez kikofernandez changed the title Adds Elixir and Gleam as languages ✨ Adds Elixir and Gleam as languages Nov 9, 2024
Signed-off-by: Kiko Fernandez-Reyes <[email protected]>
Signed-off-by: Kiko Fernandez-Reyes <[email protected]>
checks/raw/fuzzing_test.go Outdated Show resolved Hide resolved
Co-authored-by: Bram Verburg <[email protected]>
Signed-off-by: Kiko Fernandez-Reyes <[email protected]>
checks/raw/fuzzing.go Outdated Show resolved Hide resolved
checks/raw/fuzzing_test.go Outdated Show resolved Hide resolved
checks/raw/fuzzing_test.go Outdated Show resolved Hide resolved
@kikofernandez
Copy link
Contributor Author

Thanks for catching the issues in Elixir and Gleam. I have also corrected the bug for the Erlang commit and added it here, unless you prefer a specific PR for the Erlang broken test.

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and quick responses! Please fix DCO and I can get this merged.

https://github.com/ossf/scorecard/pull/4408/checks?check_run_id=33054586665

Signed-off-by: Kiko Fernandez-Reyes <[email protected]>
@kikofernandez
Copy link
Contributor Author

I have fixup (squash) some commits together and re-add the forgotten signed-off-by.
Also, I finally run tests locally, so this is the good final commit.

@kikofernandez
Copy link
Contributor Author

Thanks for the contribution and quick responses! Please fix DCO and I can get this merged.

https://github.com/ossf/scorecard/pull/4408/checks?check_run_id=33054586665

@spencerschrock Thanks again for your fast response rate!
I wished I had got it right the first time, and dinner time with kids did not help. But the end result is what matters :)

Thanks again!

@spencerschrock
Copy link
Member

I wished I had got it right the first time, and dinner time with kids did not help

No worries, family comes first :)

@spencerschrock spencerschrock merged commit 390e7e4 into ossf:main Nov 15, 2024
36 checks passed
@kikofernandez kikofernandez deleted the elixir-gleam branch November 15, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants