Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track untestable features and exclude them from feature coverage reports #1181

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

queengooborg
Copy link
Member

This fixes #1137.

@queengooborg queengooborg temporarily deployed to mdn-bcd-collector-pr-1181 February 11, 2024 07:47 Inactive
@queengooborg queengooborg merged commit e970bff into main Feb 11, 2024
5 checks passed
@queengooborg queengooborg deleted the track-untestable-features branch February 11, 2024 07:49
@Elchi3
Copy link
Member

Elchi3 commented Feb 12, 2024

I wonder if we should limit this list to untestable features in the sense that we only list untestable things that require specific hardware etc. For things like worker support, it seems that we can test these one day, but work on the collector is required, right? I think those shouldn't be classified as "untestable".

@queengooborg
Copy link
Member Author

The list is separated into two sections, with comments annotating each one: the truly untestable features, and the features that are testable but would require an overhaul of collector architecture. Worker support is one of those overhaul-requiring features.

While it's a misnomer to put it in the "untestable features" list, I don't think that it's worth trying to implement support for those kinds of features right now, so that's why I put them in the list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track untestable features somehow
2 participants