Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling errors #2586

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from

Conversation

Dimitrolito
Copy link

  • Fixed spelling mistake: "commited" to "committed" in commit_reveal.py.
  • Corrected the typo "tyep" to "type" in networking.py.

ibraheem-opentensor and others added 3 commits January 17, 2025 08:57
* Updates tests for btwallet 3.0.0

* fix get_delegates result decoding

* Feat/use tx pool for set weights (opentensor#2534)

* use the tx pool for setting/committing weights

* add supports rpc method with cache

* handle when state call is not possible (unlikely)

* increment next index by one for correct nonce

* use for set sync set weights also

* oops, define in subtensor for sync methods

* make tests less specific

* try e2e test for commit weights

* modify comments on test

* add root set test helper

* try upping submit timeout

* add set weights e2e test

* use high timeout on tests

* add awaits and log netuid

* chore: ruff

* use sudo_set_admin_utils instead

* don't increment next index for nonce

* dont await sudo_set_admin_utils

* lower test ext timeout to 12

* enable reg during test

* use set hyp values instead

* sleep after setting reg allowed

* fix test_set_weights_uses_next_nonce

* Use asyncstdlib for lru_cache of `AsyncSubstrateInterface.supports_rpc_method`

* Increases sleep for txs in test_set_weights_uses_next_nonce

---------

Co-authored-by: Benjamin Himes <[email protected]>
Co-authored-by: ibraheem-opentensor <[email protected]>
Co-authored-by: Benjamin Himes <[email protected]>

* fix tests

* add connection limit error handler

* add test

* Backmerge master to staging post 851 (opentensor#2557)

Bumps version and changelog

* improve handler

* add async commit reveal impl

* add new logic to async_subtensor

* add unit tests

* ruff

* add uid check before processing

* fix test

* Use apt-get instead of apt for scripts (opentensor#2571)

apt --> apt-get

* fix _do_stake incorrect arguments error in staking.py

add_stake sdk (after pybytes error is fixed in delegate_info.py) another error occurs, because _do_stake is incorrectly called on line 124 in staking.py returning an invalid arguments error, must add self (subtensor) param to fix this error.

* Updates subtensor branch for e2e

* tests fix

* Bumps cr3 ffi

* Bumps version and changelog

* Updates changelog

---------

Co-authored-by: Roman <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>
Co-authored-by: Benjamin Himes <[email protected]>
Co-authored-by: Benjamin Himes <[email protected]>
Co-authored-by: Roman <[email protected]>
Co-authored-by: Assh-codes <[email protected]>
thewhaleking
thewhaleking previously approved these changes Jan 18, 2025
@thewhaleking thewhaleking changed the base branch from master to staging January 18, 2025 18:25
@thewhaleking thewhaleking dismissed their stale review January 18, 2025 18:25

The base branch was changed.

Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Will merge after back-merging master to staging. In the future, please base all PRs off of staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants