Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

bumped versions for Commander and Highline for 2.3.0 compatibility #744

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dydx
Copy link

@dydx dydx commented Jan 26, 2016

Running rhc on Ruby 2.3.0 systems, there is a depreciation warning in Commander. Commander recently released a patch and then a new release to address this. The new version of Commander is dependent on a more recent version of Highline. I bumped the versions for both of these.

initial error:

/Users/josh/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/commander-4.3.0/lib/commander/user_interaction.rb:326: warning: constant ::TimeoutError is deprecated

commander update:
commander-rb/commander@b87df80

Running `rhc` on Ruby 2.3.0 systems, there is a depreciation warning in Commander. Commander recently released a patch and then a new release to address this. The new version of Commander is dependent on a more recent version of Highlign. I bumped the versions for both of these
@openshift-bot
Copy link

openshift-bot commented Jul 20, 2016

Online Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@voxik
Copy link

voxik commented Oct 13, 2016

This related to #684 and #673

@AlecRust
Copy link

Any update on this?

@tjnapster555
Copy link

@dydx the problem is still their when i run rhc in windows it still show Commander warnings

@Lucas-C
Copy link

Lucas-C commented Mar 27, 2018

@dydx : this looks like a great fix !
Thanks.
Do you think you could rebase your PR please, so that maintainers of this project can merge it ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants