Add support for ExtraPartitionSize to address issue #676

[xphyr]

Background / Context

This PR addresses the inability to reserve some space on the install device for other partitions. By allowing for additional partitions on the install disk we can create partitions for use by other processes, such as the LVM Operator.

Issue / Requirement / Reason for change

This PR addresses issue #676

Solution / Feature Overview

I have added one extra configuration option "ExtraPartitionSize" which allows you to define the size of the varlibcontainers partition that is created. It is a optional configuration. If you do not define this option, the lca-cli works exactly the same as it did prior to this code change. This means that all existing configuration files will work with no changes.

Implementation Details

This change takes advantage of the existing "sgdisk" code and appends the required additional value of ExtraPartitionSize to the "new" command, allowing us to specify a total size. By defaulting "ExtraPartitionSize" to "0" the any previous config files that did not specify this value will work without any modification.

Other Information

Given that MCO can not be used to configure additional partitions the lca-cli utility should be updated to support the creation of additional partitions as part of the image application process. In theory this can be handled by adding a "post.sh" with the additional commands, but it would be easier if it was built into the utility itself.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @xphyr. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mresvanis]

/ok-to-test

[mresvanis]

/test ci-job

[openshift-ci]

@xphyr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ci-job	26c67f8	link	true	/test ci-job

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mresvanis]

There seems to be an issue with this change in the CI, specifically I noticed the following here:

go vet ./...
# github.com/openshift-kni/lifecycle-agent/lca-cli/ibi-preparation
vet: lca-cli/ibi-preparation/ibipreparation_test.go:17:2: ibiconfig redeclared in this block

I didn't look into the cause of this, but I think if we moved this line to line 16 in the same file (i.e. before the other lifecycle-agent import) , it should resolved the CI issue. @xphyr could you perhaps give it a try?