CNF-11231: Compare Multus and SR-IOV metrics #2025
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
zeeke
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@zeeke: This pull request references CNF-11231 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-telco5g-cnftests |
zeeke
force-pushed
the
CNF-11231/metrics-comparison-with-multus
branch
from
4e16d49
to
b6a6594
Compare
|
/test e2e-telco5g-cnftests |
zeeke
force-pushed
the
CNF-11231/metrics-comparison-with-multus
branch
from
b6a6594
to
7a22067
Compare
|
/test e2e-telco5g-cnftests |
zeeke
force-pushed
the
CNF-11231/metrics-comparison-with-multus
branch
from
7a22067
to
663753e
Compare
|
/test e2e-telco5g-cnftests |
|
/retest |
SR-IOV Network Operator dependency bumped with commands: ``` go install -mod=mod github.com/openshift/[email protected] go mod edit -replace \ github.com/k8snetworkplumbingwg/sriov-network-operator=\ github.com/openshift/[email protected] go mod tidy go mod vendor ``` Signed-off-by: Andrea Panattoni <[email protected]>
Statistics that relates to Multus interfaces can be collected by joining network-metrics-daemon [1] and cAdvisor [2] (see [3]). The same information, for kernel netdevice SR-IOV interface can be collected via the `sriov-network-metrics-exporter` [4], which leverages the Physical Function to get statistics about the Virtual Functions. Proposed test case verifies both sources produces congruent values. Only TX statistics are verified, as receiving ones might be spoiled by noise traffic on the wire (e.g. other nodes sending DHCP broadcast requests). [1] https://github.com/openshift/network-metrics-daemon [2] https://github.com/google/cadvisor/blob/master/docs/storage/prometheus.md [3] https://docs.openshift.com/container-platform/4.16/networking/associating-secondary-interfaces-metrics-to-network-attachments.html#cnf-associating-secondary-interfaces-metrics-with-network-name_secondary-interfaces-metrics [4] https://github.com/k8snetworkplumbingwg/sriov-network-metrics-exporter Signed-off-by: Andrea Panattoni <[email protected]>
zeeke
force-pushed
the
CNF-11231/metrics-comparison-with-multus
branch
from
663753e
to
82dcd4e
Compare
|
/test e2e-telco5g-cnftests |
1 similar comment
|
/test e2e-telco5g-cnftests |
|
@zeeke: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Statistics that relate to Multus interfaces can be collected by
joining network-metrics-daemon [1] and cAdvisor [2] (see [3]).
The same information, for kernel netdevice SR-IOV interface can be
collected via the
sriov-network-metrics-exporter[4], which leveragesthe Physical Function to get statistics about the Virtual Functions.
Proposed test case verifies both sources produce congruent values.
Only TX statistics are verified, as receiving ones might be spoiled by
noise traffic on the wire (e.g. other nodes sending DHCP broadcast
requests).
Bump sriov-network-operator API to access the new field
SriovOperatorconfig.Spec.FeatureGates[1] https://github.com/openshift/network-metrics-daemon
[2] https://github.com/google/cadvisor/blob/master/docs/storage/prometheus.md
[3] https://docs.openshift.com/container-platform/4.16/networking/associating-secondary-interfaces-metrics-to-network-attachments.html#cnf-associating-secondary-interfaces-metrics-with-network-name_secondary-interfaces-metrics
[4] https://github.com/k8snetworkplumbingwg/sriov-network-metrics-exporter