Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update log-container-sidecarset.md 格式问题 #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update log-container-sidecarset.md 格式问题 #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions docs/best-practices/log-container-sidecarset.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ spec:
valueFrom:
fieldRef:
apiVersion: v1
fieldPath: metadata.namespace
fieldPath: metadata.namespace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz correct valueFrom field as well, its indentation is also incorrect.

image: docker.elastic.co/beats/filebeat:7.16.2
livenessProbe:
exec:
Expand Down Expand Up @@ -138,12 +138,13 @@ spec:
# Share log directory with app container via volumeMount
- mountPath: /var/log
name: log
volumes:
- configMap:
name: filebeat-config
#hzj change
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz remove this comment

volumes:
- configMap:
name: filebeat-config
- name: log
emptyDir: {}
name: filebeat-config
- name: log
emptyDir: {}
```
**For the scenario where machine resources are not sufficient, in order to reduce Pod resource requests, you can set sidecar container request.cpu=0. In this case, the Qos of Pod will be [Burstable](https://kubernetes.io/docs/tasks/configure-pod-container/quality-service-pod/#create-a-pod-that-gets-assigned-a-qos-class-of-burstable).**

Expand Down
Loading