Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added script to generate c header from yaml and generated header #1733

Draft
wants to merge 1 commit into
base: cv32e40s/dev
Choose a base branch
from

Conversation

silabs-hfegran
Copy link
Contributor

No description provided.

Copy link
Contributor

@silabs-robin silabs-robin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be some license header issues, but I'm approving ahead of time since the files otherwise look good, assuming that the license issues will be resolved.

################################################################################
#
# Copyright 2020 OpenHW Group
# Copyright 2020 Silicon Labs, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 2022 or 2023.

And I think @MikeOpenHWGroup said before that the openhw group copyright line isn't really necessary?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. I will add it if I create a file, but other members are not expected to. There is no significant impact if do grant OpenHW copyright (I am sure a lawyer would point out that assigning copyright to OpenHW means that OpenHW will have standing as an "injured party" should somebody violate the license.)

...and yes, 2020 s.b. 2023.

** Copyright 2021 OpenHW Group
** Copyright 2021 Silicon Labs
**
** Licensed under the Solderpad Hardware Licence, Version 2.0 (the "License");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably have an SPDX line too.

@@ -0,0 +1,955 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! I like this new bsp header.

} __attribute__((packed)) volatile timeh_t;


typedef union {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script issue here - should not have multiple mhpmcounter-type defs

#define MSCRATCHCSW 0x348
#define MSCRATCHCSWL 0x349
#define TSELECT 0x7A0
#define TDATA1 0x7A1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What can we do about tdata1? It doesn't seem to have a struct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet another corner case... I need to add a list of corner cases to the script - generally I do not want multiple definitions for registers that have n-number of instances, but there are some that actually require this. I will add a do not merge to this PR and handle that.

@silabs-hfegran silabs-hfegran marked this pull request as draft May 5, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants