Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to createBuildContext to fix #1001 #1002

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

welteki
Copy link
Member

@welteki welteki commented Aug 7, 2024

Description

Fix nil pointer dereference when getting the build options packages.

Motivation and Context

  • I have raised an issue to propose this change (required)

Fixes #1001

How Has This Been Tested?

  • Verified the faas-cli up command works for function using the dockerfile template.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

derek bot commented Aug 7, 2024

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "[email protected]"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

Revert to fix openfaas#1001
The CreateBuildContext will be moved to the go-sdk in later PR.

This reverts commit 35dc699.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis changed the title Fix builder for dockerfile template Revert changes to createBuildContext to fix #1001 Aug 7, 2024
@alexellis alexellis merged commit 7264f71 into openfaas:master Aug 7, 2024
1 check passed
@welteki welteki deleted the fix-build branch August 7, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI release 0.16.32: runtime error when invoking faas up
2 participants