Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector Databse Milvus Tutorial Migrated to Higher-Level MilvusClient SDK #1548

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jinhonglin-ryan
Copy link

Summary

Migrate Milvus database interaction from a low-level ORM SDK to the higher-level MilvusClient SDK. The goal is to streamline operations, improve code readability, and simplify maintenance by utilizing MilvusClient's higher-level abstractions.

Motivation

The changes in this PR make our codebase more efficient and reduce complexity by switching to MilvusClient. This transition enables us to streamline the embedding and querying process for datasets such as movie descriptions (with metadata filtering) and book descriptions (simple retrieval), aligning our codebase with current best practices and making it easier for developers to extend and maintain.

Getting Started with Milvus and OpenAI: Introduces the use of Milvus for embedding-based search on book descriptions, embedding the descriptions with OpenAI and storing them for retrieval in Milvus.

Filtered Search with Milvus and OpenAI: Demonstrates how to use Milvus for vector similarity search on movie descriptions, utilizing OpenAI embeddings and Milvus's filtering capabilities.


For new content

When contributing new content, read through our contribution guidelines, and mark the following action items as completed:

  • [ ✅ ] I have added a new entry in registry.yaml (and, optionally, in authors.yaml) so that my content renders on the cookbook website.
  • [ ✅ ] I have conducted a self-review of my content based on the contribution guidelines:
    • [ ✅ ] Relevance: This content is related to building with OpenAI technologies and is useful to others.
    • [ ✅ ] Uniqueness: I have searched for related examples in the OpenAI Cookbook, and verified that my content offers new insights or unique information compared to existing documentation.
    • [ ✅ ] Spelling and Grammar: I have checked for spelling or grammatical mistakes.
    • [ ✅ ] Clarity: I have done a final read-through and verified that my submission is well-organized and easy to understand.
    • [ ✅ ] Correctness: The information I include is correct and all of my code executes successfully.
    • [ ✅ ] Completeness: I have explained everything fully, including all necessary references and citations.

We will rate each of these areas on a scale from 1 to 4, and will only accept contributions that score 3 or higher on all areas. Refer to our contribution guidelines for more details.

@zc277584121
Copy link

Yes. Milvus currently recommends using the MilvusClient SDK , e.g.https://milvus.io/docs/build-rag-with-milvus.md#Load-data-into-Milvus . So it's a good update.

@jinhonglin-ryan
Copy link
Author

Hi @ericning-o, @pap-openai, @shyamal-anadkat,

I wanted to check in on this pull request to see if there’s any additional context or adjustments I could provide to streamline the review process. Please let me know if I’ve missed anything or if you have any feedback—I’d be happy to make any necessary updates promptly.

Thank you for your time and consideration!

@zc277584121
Copy link

hello, @joecasson-openai, @msingh-openai, can you please take a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants