Added BatchSpanProcessor metrics on drop and export span #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamunto
requested review from
nachoBonafonte,
bryce-b and
vvydier
as code owners
mamunto
commented
Nov 11, 2024
Comment on lines
+113
to
+124
| self.queueSizeGauge = meter.gaugeBuilder(name: "queueSize") | ||
| .ofLongs() | ||
| .setDescription("The number of items queued") | ||
| .setUnit("1") | ||
| .buildWithCallback { result in | ||
| result.record( | ||
| value: maxQueueSize, | ||
| attributes: [ | ||
| BatchSpanProcessor.SPAN_PROCESSOR_TYPE_LABEL: .string(BatchSpanProcessor.SPAN_PROCESSOR_TYPE_VALUE) | ||
| ] | ||
| ) | ||
| } |
There was a problem hiding this comment.
I followed Java SDK implementation and convention, and here maxQueueSize will be always fixed. Is that a right use case?
|
|
||
| func addSpan(span: ReadableSpan) { | ||
| cond.lock() | ||
| defer { cond.unlock() } | ||
|
|
||
| if spanList.count == maxQueueSize { | ||
| // TODO: Record a counter for dropped spans. | ||
| processedSpansCounter.add(value: 1, attribute: droppedAttrs) | ||
| return | ||
| } | ||
| // TODO: Record a gauge for referenced spans. |
There was a problem hiding this comment.
I'm not clear on proper use-case here. Please explain the use-case and I can add the functionality @nachoBonafonte @bryce-b
Comment on lines
+213
to
+215
| cond.lock() | ||
| processedSpansCounter.add(value: spanList.count, attribute: exportedAttrs) | ||
| cond.unlock() |
There was a problem hiding this comment.
I'm using same lock here to modify the counter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added BatchSpanProcessor metrics on drop and export span