Prototypes proposed spec changes to allow extraction of multiple header values #5973
+93
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, extending TextMapCarrier. Gives example extracting requests with multiple 'baggage' headers set.
jamesmoessis
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5973 +/- ##
=======================================
- Coverage 84.6% 84.6% -0.1%
=======================================
Files 272 272
Lines 22897 22918 +21
=======================================
+ Hits 19391 19401 +10
- Misses 3162 3173 +11
Partials 344 344 |
pellared
reviewed
Nov 14, 2024
jack-berg
reviewed
Nov 15, 2024
| multiCarrier, isMultiCarrier := carrier.(MultiTextMapCarrier) | ||
| if isMultiCarrier { | ||
| return extractMultiBaggage(parent, multiCarrier) | ||
| } |
pellared
reviewed
Nov 15, 2024
There was a problem hiding this comment.
I think your prototype is good. For an actual PR we would need to improve the docs and call out the MultiTextMapCarrier in more places.
PS. Not feeling well today so treat my review with low confidence (like an pre-approval). I will do my best to look at it again once I recover and have a clearer mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiTextMapCarrier, extendingTextMapCarrier- addsGetAll(string) []string.MultiTextMapCarrierforHeaderCarrierpropagator.Baggageto use theGetAll()method if it's implemented.Does not introduce any breaking changes or alter any existing tests.
Spec issue: open-telemetry/opentelemetry-specification#433
Corresponding Java prototype: open-telemetry/opentelemetry-java#6852