feat(googlecloudmonitoring): support monitoring filters #37264
Conversation
chenlujjj
requested review from
dashpole,
TylerHelmuth and
a team
as code owners
chenlujjj
force-pushed
the
feat-googlecloudmonitoring-filter
branch
from
1cc5e3f to
81dff4e
Compare
chenlujjj
changed the title
chenlujjj
force-pushed
the
feat-googlecloudmonitoring-filter
branch
from
acf2409 to
31522d0
Compare
chenlujjj
force-pushed
the
feat-googlecloudmonitoring-filter
branch
from
31522d0 to
6fd50f2
Compare
|
|
||
| One of `metric_name` and `monitoring_filter` MUST be specified, but should not be specified at the same time. |
There was a problem hiding this comment.
| One of `metric_name` and `monitoring_filter` MUST be specified, but should not be specified at the same time. | |
| One of `metric_name` and `monitoring_filter` MUST be specified, but MUST not be specified at the same time. |
|
|
||
| One of `metric_name` and `monitoring_filter` MUST be specified, but should not be specified at the same time. |
There was a problem hiding this comment.
Based on https://cloud.google.com/monitoring/api/v3/filters, if we are applying these to only to ListMetricDescriptor, there are a lot of restrictions on what you can filter by that might confuse users. They can't use resource or group selectors, and presumably can't filter on labels: metric.labels.instance_name = monitoring.regex.full_match("gke-(hipster|nginx).*").
One solution would be to make this a metric_descriptor_filter config option, so that it is clear we are filtering metric descriptors (and we should also document that there are restrictions on that filter). That way we could later add a separate time_series_filter that we add to actual ListTimeSeries queries if we want.
Description
Link to tracking issue
Fixes part of #36898
Testing
Documentation