Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jbr jcef #1038

Merged
merged 31 commits into from
Oct 6, 2024
Merged

jbr jcef #1038

merged 31 commits into from
Oct 6, 2024

Conversation

StageGuard
Copy link
Member

@StageGuard StageGuard commented Oct 2, 2024 •
edited
Loading

Gradle JVM Toolchain is locked to JBR-JCEF 17.

@StageGuard
Copy link
Member Author

StageGuard commented Oct 3, 2024 •
edited
Loading

需要改进的问题：

  • CI 构建改成 JBR
  • jbr bin 里的 icudtl.dat ， jcef_helper.exe 和 v8_context_snapshot.bin 没被打包，需要写个 task 手动复制
  • CONTRIBUTING.md 提醒要用 JBR-JCEF 17，放上下载链接，注明要下载 JBR with JCEF (bundled by default)
  • MacOS test

setup-java action 目前没有官方支持的 JBR，但是有人做了 workaround
@Him188 你觉得要用这个吗

@StageGuard
Copy link
Member Author

ping @Him188

@Him188
Copy link
Member

Him188 commented Oct 3, 2024

我觉得可以

@StageGuard StageGuard enabled auto-merge (squash) October 5, 2024 16:48
Him188
Him188 requested changes Oct 5, 2024
View reviewed changes
app/desktop/build.gradle.kts Outdated Show resolved Hide resolved
@Him188 Him188 disabled auto-merge October 5, 2024 19:45
@Him188 Him188 merged commit 8e2f6c0 into main Oct 6, 2024
6 checks passed
@Him188 Him188 deleted the jbr-jcef branch October 6, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Him188 Him188 Him188 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StageGuard @Him188