-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply dataclass transform to AtomMeta #210
Open
MatthieuDartiailh
wants to merge
13
commits into
main
Choose a base branch
from
dataclass-transform
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still use the "old" method of just using members directly but this looks fine to me. |
All members are declared as field specifiers.
MatthieuDartiailh
force-pushed
the
dataclass-transform
branch
from
March 25, 2024 16:32
0c93f70
to
3f96820
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
- Coverage 97.67% 95.93% -1.74%
==========================================
Files 24 24
Lines 1075 1181 +106
Branches 174 200 +26
==========================================
+ Hits 1050 1133 +83
- Misses 12 29 +17
- Partials 13 19 +6 |
…to set more default modes and metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All members are declared as field specifiers which allow to use them in addition of an annotation.
I am considering adding other field specifiers to:
I am considering something along the following lines to stay close to the existing syntax.
Any opinion @frmdstryr
Closes #173