Remove the default engine behavior in internal applicative eval functions #41
+39
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Following a change #38 in how dependencies are provided, services importing Nodely (indirectly through
nodely-helpers
) began facing errors. This occurred because services were not explicitly providingpromesa
as a dependency, even if they were not using it.The issue stemmed from Nodely's applicative engine eval functions, which would default to using the promesa engine if no engine was specified. This resulted in
promesa
being included as a required dependency.Since applicative eval functions are intended for internal use only and are accessed through the API, which sets the
core-async
engine when no engine is provided, the decision was made to remove the behavior of having a default engine at applicative eval functions.