test: fix build on 32bit platforms #500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduce with: $ GOARCH=386 go test -v github.com/notaryproject/notation-go ./notation_test.go:763:26: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in struct literal (overflows) FAIL github.com/notaryproject/notation-go [build failed] FAIL Signed-off-by: Reinhard Tartler <[email protected]>
siretart
requested review from
gokarnm,
JeyJeyGao,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
Two-Hearts,
vaninrao10 and
yizha1
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
=======================================
Coverage 80.47% 80.47%
=======================================
Files 35 35
Lines 3344 3344
=======================================
Hits 2691 2691
Misses 508 508
Partials 145 145 ☔ View full report in Codecov by Sentry. |
Two-Hearts
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
LGTM.
@siretart the commit needs to be signed before merging.
shizhMSFT
changed the title
|
@siretart Thanks for adding 32bit arch support. Would you mind sharing your use case? I am curious on your scenario. |
|
I'm packaging this library for Debian, and we test it on like a dozen different architectures. The use case can be described as having the notation cli binary prebuilt for as many architectures as possible so that it can be made available a regular Debian package and available via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce with:
$ GOARCH=386 go test -v github.com/notaryproject/notation-go
./notation_test.go:763:26: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in struct literal (overflows)
FAIL github.com/notaryproject/notation-go [build failed]
FAIL
Signed-off-by: Reinhard Tartler [email protected]