Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use starts_with in fs_permission.cc #55811

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: use starts_with in fs_permission.cc #55811

wants to merge 1 commit into from

Conversation

IlyasShabi
Copy link
Contributor

Use starts_with from C++20 instead of substr in fs_permission.cc

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 10, 2024
@RedYetiDev
Copy link
Member

Does this need to be benchmarked?

@codecov Codecov
Copy link

codecov bot commented Nov 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (58a8eb4) to head (5f894e6).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55811   +/-   ##
=======================================
  Coverage   88.40%   88.41%           
=======================================
  Files         654      654           
  Lines      187815   187815           
  Branches    36136    36139    +3     
=======================================
+ Hits       166045   166049    +4     
- Misses      15001    15010    +9     
+ Partials     6769     6756   -13
Files with missing lines Coverage Δ
src/permission/fs_permission.cc 70.86% <ø> (ø)

... and 24 files with indirect coverage changes

@anonrig anonrig added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Nov 10, 2024
@anonrig
Copy link
Member

anonrig commented Nov 10, 2024

Does this need to be benchmarked?

No. It's not that different.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2024
@RedYetiDev RedYetiDev added fs Issues and PRs related to the fs subsystem / file system. permission Issues and PRs related to the Permission Model labels Nov 11, 2024
@RafaelGSS RafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 11, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63505/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63509/

@IlyasShabi
Copy link
Contributor Author

I think these are flaky tests. Could someone please rerun the CI?

@aduh95
Copy link
Contributor

aduh95 commented Nov 14, 2024

I think these are flaky tests. Could someone please rerun the CI?

It's not working atm, the incident is tracked at nodejs/build#3959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@IlyasShabi @nodejs-github-bot @RedYetiDev @anonrig @aduh95 @lpinca @RafaelGSS