build: remove support for s390 32-bit #291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 13.1. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
dllexport introduces issues when compiling with MSVC. PR-URL: nodejs/node#47251 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Richard Lau <[email protected]>
It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: nodejs/node#47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902 PR-URL: nodejs/node#47450 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs/node#54077 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
After enabling -std:c++20 on Windows, patch is now much smaller. PR-URL: nodejs/node#52465 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs/node#53134 Refs: nodejs/node#52809 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
It's causing compiler errors with some classes on Xcode 11 and the attribute should have no runtime effect. PR-URL: nodejs/node#54077 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
V8 removed support for it. Refs: v8/v8@6437539
On AIX, we now include src/wasm/float16.h from within src/utils/utils.h and src/wasm/float16.h includes additional header files.
V8 removed support for it. Refs: v8/v8@9565a9a
targos
approved these changes
Sep 19, 2024
|
Pushed to |
|
https://github.com/nodejs/node-v8/actions/runs/10935492362 is running with it. |
nodejs-github-bot
force-pushed
the
canary
branch
6 times, most recently
from
6ae0f79
to
b9a77a3
Compare
nodejs-github-bot
force-pushed
the
canary
branch
6 times, most recently
from
9bcfd21
to
e42e09a
Compare
nodejs-github-bot
force-pushed
the
canary
branch
8 times, most recently
from
8772638
to
d5a0e0c
Compare
nodejs-github-bot
force-pushed
the
canary
branch
4 times, most recently
from
b538653
to
4f9649c
Compare
nodejs-github-bot
force-pushed
the
canary
branch
8 times, most recently
from
9e40940
to
c1ddb65
Compare
nodejs-github-bot
force-pushed
the
canary
branch
8 times, most recently
from
37db4c4
to
fa88014
Compare
nodejs-github-bot
force-pushed
the
canary
branch
2 times, most recently
from
c389add
to
c7f4c5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 removed support for it.
Refs: v8/v8@9565a9a
Failure after v8/v8@9565a9a: