feat: prohibit compiling with ClangCL on Windows #3098
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disables trying to compile with ClangCL on Windows. Was required to enable native tests in the Node.js CI for the ClangCL produced binaries. Refs: nodejs/node#55784
|
FYI the |
|
The failing Python lint issues are fixed in |
Thanks for letting me know. I'll rebase after that PR lands. |
|
That PR has landed but a |
|
Could someone please review and approve this so it can be landed? It was already approved as part of a bigger change (this is the change needed in node-gyp) in nodejs/node#55784 and I'd like to push this forward so we can enable ClangCL in the Windows CI. |
StefanStojanovic
added a commit
to JaneaSystems/node
that referenced
this pull request
Nov 29, 2024
This change cherry-picks a small change from node-gyp needed for running native tests on ClangCL compiled binaries. Refs: nodejs/node-gyp#3098
lukekarrys
pushed a commit
that referenced
this pull request
Dec 2, 2024
Disables trying to compile with ClangCL on Windows. Was required to enable native tests in the Node.js CI for the ClangCL produced binaries. Refs: nodejs/node#55784
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is opened based on nodejs/node#55784 as it is required to enable running native (addon) tests for the ClangCL-produced binaries on Windows. The original PR is reviewed and approved in the Node.js repo and I'm moving to the next phase now - landing the changes in their respective repositories. Node-gyp is the only dependency that needs changing outside Node.js, so I've decided to start with it.