Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try libnode.dll first in load_exe_hook #2834

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

zombieyang
Copy link
Contributor

@zombieyang zombieyang commented Apr 26, 2023

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

It is a following PR of nodejs/node#47682.

I've tried to rename my executable to node.exe but the error is still there.
That's because the node.js's symbol is in libnode.dll but not in my executable. So, GetModuleHandle(NULL) will not work.

However, I think we can try to load libnode.dll first. If failed then fallback to try the executable. That will solve the problem and keep the original path work either.
Maybe it is looks like a edge case, but as Node.js has a embedding tutorial in the doc, I think it's worth to do this.

Or please tell me if there is a more simple way to solve my problem.


Test is not included because I need to provide a huge nodedll binary.

Thank you, I love node.js.

@Kreijstal
Copy link

Can anyone review?

@zombieyang
Copy link
Contributor Author

I'm not quite sure if it still make sense after such a long time. Maybe you can consider cherry-picking dd56ec0

@lukekarrys
Copy link
Member

I have rebased this PR to include only dd56ec0

@Kreijstal
Copy link

I have rebased this PR to include only dd56ec0

Thank you

@zombieyang
Copy link
Contributor Author

I have rebased this PR to include only dd56ec0

Thank you, will it merge?

@Kreijstal
Copy link

I have rebased this PR to include only dd56ec0

Thank you, will it merge?

i hope so

@lukekarrys lukekarrys merged commit 0d00253 into nodejs:main Dec 13, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants