Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update example app to standalone #4487

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

sheikalthaf
Copy link
Contributor

@sheikalthaf sheikalthaf commented Aug 8, 2024

Updated the example app to standalone, removed all the modules from app.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 6312a4c
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/66f9bbb4a45b4600087484de

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @sheikalthaf .
I left a few comments for some details.

Can you also take a look at the pipeline, it currently has some failing tests and ESLint issues.
For more details see https://github.com/ngrx/platform/pull/4487/checks?check_run_id=28492422455

projects/example-app/src/app/app.routing.ts Show resolved Hide resolved
projects/example-app/src/app/app.config.ts Outdated Show resolved Hide resolved
projects/example-app/src/app/app.config.ts Outdated Show resolved Hide resolved
projects/example-app/src/app/app.config.ts Outdated Show resolved Hide resolved
@rainerhahnekamp
Copy link
Contributor

Hey, looks like we have a duplicate for this: #4417. Was there a second issue, or should I assign @sheikalthaf to it?

@brandonroberts
Copy link
Member

@rainerhahnekamp it was assigned to you, so you still have first choice.

@rainerhahnekamp
Copy link
Contributor

rainerhahnekamp commented Aug 8, 2024

@sheikalthaf, please keep in mind the contribution guide (https://github.com/ngrx/platform/blob/main/CONTRIBUTING.md).

We usually open an issue and assign it to you. Only then should you submit a PR. Otherwise, multiple developers will be working on the same task.

In this case, I am going to assign the issue to you, but please check the issues first for the next one.

Please add a short comment in #4417, so that I can select you from the user list.

Thanks!

@sheikalthaf
Copy link
Contributor Author

@rainerhahnekamp thanks for pointing out. sorry I don't know about that. From next time I'll check the issue comments clearly. Sorry for the confusion here.

@timdeschryver
Copy link
Member

Woops, sorry @rainerhahnekamp I missed that during my initial review.

@sheikalthaf
Copy link
Contributor Author

@timdeschryver this is the only testcase is failing and i see that the snapshot is wrong. Can you help me here
image

@sheikalthaf sheikalthaf marked this pull request as draft August 12, 2024 17:41
@sheikalthaf
Copy link
Contributor Author

@rainerhahnekamp and me going to work together on this PR. For now I'm making this as a Draft until the pipeline is fixed.
@rainerhahnekamp currently linting is failing, can you help me here.

@timdeschryver FYI

@rainerhahnekamp
Copy link
Contributor

@sheikalthaf yup, I will check

@sheikalthaf sheikalthaf marked this pull request as ready for review October 14, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants